-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor System::Clock cleanup #10153
Merged
Merged
Minor System::Clock cleanup #10153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Followups from PR project-chip#10056 Indirect access for System::Clock functions Fixes project-chip#10146 Remove GetMonotonicMicroseconds() call Fixes project-chip#10145 remove. Fixes project-chip#10144 The static cast should have the / 1000 within it #### Change overview - Removes the global backward-compatibility wrappers for `GetMonotonic…()`. - Correctly parenthesize the project-chip#10146 cast. #### Testing CI. No changes to functionality intended.
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
shana-apple and
vivien-apple
October 1, 2021 15:26
Size increase report for "gn_qpg-example-build" from 80df9f2
Full report output
|
Size increase report for "nrfconnect-example-build" from 80df9f2
Full report output
|
Size increase report for "esp32-example-build" from 80df9f2
Full report output
|
andy31415
approved these changes
Oct 1, 2021
saurabhst
approved these changes
Oct 1, 2021
emargolis
approved these changes
Oct 2, 2021
@project-chip/reviewers-apple ? @Damian-Nordic @jepenven-silabs @jmartinez-silabs @hawk248 @jelderton @LuDuda @chrisdecenzo ? |
jmartinez-silabs
approved these changes
Oct 4, 2021
Damian-Nordic
approved these changes
Oct 4, 2021
msandstedt
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Followups from PR #10056 Indirect access for System::Clock functions
Fixes #10146 Remove GetMonotonicMicroseconds() call
Fixes #10145 remove.
Fixes #10144 The static cast should have the / 1000 within it
Change overview
GetMonotonic…()
.Testing
CI. No changes to functionality intended.