Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESP32] ConnectivityManagerImpl — should UpdateInternetConnectivityState() happen if PostEvent() fails? #9577

Open
kpschoedel opened this issue Sep 9, 2021 · 4 comments
Assignees
Labels

Comments

@kpschoedel
Copy link
Contributor

Problem

In src/platform/ESP32/ConnectivityManagerImpl.cpp, there are several functions that both call PlatformMgr().PostEvent() and UpdateInternetConnectivityState() (in either order). With PR #9573, PostEvent() returns an error if it fails. It's not obvious whether UpdateInternetConnectivityState() should be called in such cases.

@yufengwangca
Copy link
Contributor

@gjc13 could you help to take a look?

@stale
Copy link

stale bot commented Dec 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

1 similar comment
@stale
Copy link

stale bot commented Jun 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jun 9, 2023
@dhrishi
Copy link
Contributor

dhrishi commented Oct 25, 2024

We will check this cc @shubhamdp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants