Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tv-casting-app CLI input should not block main thread #9217

Closed
sharadb-amazon opened this issue Aug 24, 2021 · 2 comments
Closed

tv-casting-app CLI input should not block main thread #9217

sharadb-amazon opened this issue Aug 24, 2021 · 2 comments
Assignees

Comments

@sharadb-amazon
Copy link
Contributor

Problem

See #8824 main.cpp. The PR sets stdin to O_NONBLOCK. The scanf() call blocks the main thread (though it does not block the event loop).

Proposed Solution

Leverage shell-common (src/lib/shell/MainLoopDefault.cpp) to accept user input.

@stale
Copy link

stale bot commented Dec 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Dec 26, 2022
@stale
Copy link

stale bot commented Jan 5, 2023

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants