Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux embeded unit tests flaky on TestPlatformTime.cpp:116 #861

Closed
woody-apple opened this issue May 27, 2020 · 4 comments · Fixed by #996
Closed

linux embeded unit tests flaky on TestPlatformTime.cpp:116 #861

woody-apple opened this issue May 27, 2020 · 4 comments · Fixed by #996
Assignees
Labels
bug Something isn't working build issue testing
Milestone

Comments

@woody-apple
Copy link
Contributor

@turon The test failure is:

Failed assert: Tdelta < (Tdelay + margin) in ../../../../../src/platform/tests/TestPlatformTime.cpp:116

That doesn't seem related to these changes. Is that test known to intermittently fail?

Originally posted by @bzbarsky-apple in #857 (comment)

@woody-apple woody-apple added this to the May 29, 2020 milestone May 27, 2020
@woody-apple woody-apple added build issue testing bug Something isn't working labels May 27, 2020
@woody-apple
Copy link
Contributor Author

@turon could you take a look? Spinning again worked...

@turon
Copy link
Contributor

turon commented May 27, 2020

@woody-apple Yes the time tests check that delays of a certain value land in a threshold window. The margin is clearly too tight for the CircleCI environment. I can relax the margins as a first pass. Worst case, we can disable those tests.

@turon
Copy link
Contributor

turon commented May 27, 2020

FYI, the test margins are currently here:
https://github.com/project-chip/connectedhomeip/blob/master/src/platform/tests/TestPlatformTime.cpp#L31

#define TEST_TIME_MARGIN_MS 2
#define TEST_TIME_MARGIN_US 500

@woody-apple
Copy link
Contributor Author

Can we up those margins for CI?

@andy31415 andy31415 changed the title Random test failure for linux embedded linux embeded unit tests flaky on TestPlatformTime.cpp:116 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build issue testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants