Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-ups of command encoder (CHIPClusters.zapt / .h / .cpp) #4503

Closed
4 tasks
erjiaqing opened this issue Jan 26, 2021 · 1 comment
Closed
4 tasks

Follow-ups of command encoder (CHIPClusters.zapt / .h / .cpp) #4503

erjiaqing opened this issue Jan 26, 2021 · 1 comment
Assignees
@vivien-apple
Labels
data model p1 priority 1 work zap
Milestone
V0.7

Comments

@erjiaqing
Copy link
Contributor

erjiaqing commented Jan 26, 2021 •
edited
Loading

Problem

After #4298 is merged, we are moving forward on CHIP Cluster support, there are a few modifications of command encoder for fully support CHIP Cluster commands.

  • Add length to support the BYTE_STRING
  • Add support for structs
  • Add support for arrays
  • Add support for group id

Proposed Solution

<suggested fix, suggested enhancement>
@erjiaqing erjiaqing changed the title Refactor command encoder Follow-ups of command encoder (CHIPClusters.zapt / .h / .cpp) Jan 27, 2021
@woody-apple woody-apple added this to the V0.7 milestone Feb 3, 2021
@erjiaqing erjiaqing mentioned this issue Feb 3, 2021
Merged
@erjiaqing erjiaqing mentioned this issue Mar 4, 2021
Merged
@woody-apple
Copy link
Contributor

SW Dev Bug Review: Closing this, as doesn't appear needed anymore and/or is complete, please reopen if needed.

This was referenced Jan 25, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vivien-apple vivien-apple

Labels
data model p1 priority 1 work zap
Projects
None yet
Milestone
V0.7
Development

No branches or pull requests
3 participants
@erjiaqing @woody-apple @vivien-apple