Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GENERATED_FUNCTION array in endpoint config template #4369

Open
jepenven-silabs opened this issue Jan 14, 2021 · 3 comments
Open

Fix GENERATED_FUNCTION array in endpoint config template #4369

jepenven-silabs opened this issue Jan 14, 2021 · 3 comments

Comments

@jepenven-silabs
Copy link
Contributor

Problem

Appbuilder, the predecessor of ZAP was a All in one application which could generate code for both the ZCL and the actual implementation. With ZAP the only information available is the one provided by the ZCL8 spec. Meaning that ZAP cannot produce code for things that he's not aware of. For example the fact that some cluster have an Init function and some doesn't have any. As a consequence the GENERATED_FUNCTION array is now being generated with a hardcoded preset since ZAP is unable to produce it.

Proposed Solution

Find a way to either :
Removed the GENERATED_FUNCTIONS array by changing the ZCL framework
Add back the GENERATED_FUNCTIONS array in a way that is easily scalable and not hardcoded directly in the helper.js file. Meaning that we should have an external way of signifying to zap if a cluster have an INIT_FUNCTION, MESSAGE_SENT_FUNCTION or PRE_ATTRIBUTE_CHANGED_FUNCTION

@woody-apple woody-apple added this to the V1.0 milestone Feb 2, 2021
@woody-apple woody-apple added the p1 priority 1 work label Feb 2, 2021
@tlykkeberg-grundfos
Copy link
Contributor

What is happening with the issue? Has it been lost or what is the intention going forward?

@woody-apple
Copy link
Contributor

It is not clear at this point, as everything behind it is quite out of date. @jepenven-silabs Can you please clarify what's needed now?

@bzbarsky-apple
Copy link
Contributor

This is very much still an issue. We are moving the lists of things into a YAML, which may help a bit, but it's still a hardcoded list in the SDK...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants