Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle subscription for Preset attributes like ActivePresetHandle, etc. that are not writeable and instead set by a command #35000

Closed
nivi-apple opened this issue Aug 14, 2024 · 0 comments · Fixed by #34936
Closed

Handle subscription for Preset attributes like ActivePresetHandle, etc. that are not writeable and instead set by a command #35000

nivi-apple opened this issue Aug 14, 2024 · 0 comments · Fixed by #34936
Assignees
@nivi-apple
Labels
thermostat_presets_v1.4_issues Label to track thermostat presets 1.4 issues

Comments

@nivi-apple
Copy link
Contributor

nivi-apple commented Aug 14, 2024 •
edited
Loading

We need to call AttributeChangedCallback when ActivePresetHandle is updated via the command SetActivePresetRequest to make sure the attribute is marked dirty and reporting picks the updated value.
@nivi-apple nivi-apple added the thermostat_presets_v1.4_issues Label to track thermostat presets 1.4 issues label Aug 14, 2024
@nivi-apple nivi-apple changed the title Handle subscription for attributes like ActivePresetHandle, pending presets, etc that are not writeable and instead set by a command Handle subscription for Preset attributes like ActivePresetHandle, etc. that are not writeable and instead set by a command Aug 14, 2024
@nivi-apple nivi-apple self-assigned this Aug 14, 2024
@hasty hasty mentioned this issue Aug 14, 2024
Merged
@mergify mergify bot closed this as completed in #34936 Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nivi-apple nivi-apple

Labels
thermostat_presets_v1.4_issues Label to track thermostat presets 1.4 issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HVAC] Sync atomic write error order with spec hasty/connectedhomeip
1 participant
@nivi-apple