Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cirque] use virtualenv #33950

Open
andy31415 opened this issue Jun 17, 2024 · 2 comments · May be fixed by #36163
Open

[Cirque] use virtualenv #33950

andy31415 opened this issue Jun 17, 2024 · 2 comments · May be fixed by #36163
Labels
CI/CD improvements Improvements to our CI/CD pipelines good first issue Good for newcomers

Comments

@andy31415
Copy link
Contributor

After upgrading to 24.04 it becomes very obvious that cirque should use a virtualenv instead of dirtying the system python packages.

We should instead create a virtualenv for every pip package install and python usage. We also seem to have significant copy&paste throughout the tests for pip install, those should be consolidated.

@FergusHuang
Copy link

@andy31415 could you review the PR #36163 ? I don't know why there is no reviewers in this PR.

@andy31415
Copy link
Contributor Author

@andy31415 could you review the PR #36163 ? I don't know why there is no reviewers in this PR.

Reviewers are not added automatically anymore as that did not seem to actually encourage reviews (we kept adding the same 20-30 people on every PR). I expect reviews to happen and that PR does have one review and probably is a candidate for fast track.

I did have a comment on it though: it requires a"how is this tested" section (or if this just changes cirque tests, a statement that cirque tests uses this and as such it is tested). I would also prefer creating things into out instead of separating out yet another folder in the top level source tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD improvements Improvements to our CI/CD pipelines good first issue Good for newcomers
Projects
Status: No status
Status: No status
2 participants