Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Non-backwards-compatible breaking change in Application Launcher cluster. #30164

Closed
bzbarsky-apple opened this issue Nov 2, 2023 · 4 comments · Fixed by #30174
Closed
Labels
bug Something isn't working darwin needs triage

Comments

@bzbarsky-apple
Copy link
Contributor

Reproduction steps

#30134 made a breaking change to client APIs by changing a writable attribute to readonly.

We need to either revert that change or figure out some other way of making the APIs continue to exist.

Bug prevalence

Always

GitHub hash of the SDK that was being used

6ec33d4

Platform

darwin

Platform Version(s)

No response

Anything else?

No response

@bzbarsky-apple
Copy link
Contributor Author

@andy31415

@andy31415
Copy link
Contributor

What is the breaking change (i.e. what methods are missing as a result)? I had assumed this was not an ABI issue.

If this is just some write* method availability, could we on-off them into some h/mm file?

@andy31415
Copy link
Contributor

andy31415 commented Nov 2, 2023

I can see no reasonable way to change the spec to make this attribute writable (what would be the meaning? Saying SHALL always return an error also seems wrong) nor do I think keeping it writable in the sdk not in the spec is that practical.

@bzbarsky-apple
Copy link
Contributor Author

If this is just some write* method availability, could we on-off them into some h/mm file?

That is what it is, and maybe we can, but this is breaking things in the meantime. I am happy to look into doing this change in a non-breaking way, but I can't do it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working darwin needs triage
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants