Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Decrease flash requirements for a Matter 1.2 SIT ICD #29131

Closed
doru91 opened this issue Sep 8, 2023 · 1 comment · Fixed by #31795
Closed

[Feature] Decrease flash requirements for a Matter 1.2 SIT ICD #29131

doru91 opened this issue Sep 8, 2023 · 1 comment · Fixed by #31795
Assignees
@kkasperczyk-no
Labels
feature request feature work flash Issues describing flash use improvements icd Intermittently Connected Devices needs triage
Milestone
Future

Comments

@doru91
Copy link
Contributor

doru91 commented Sep 8, 2023

Feature description

icd

Compilation with chip_enable_icd_server=1 + ICDM Cluster Enabled leads to a flash increase of ~5K on NXP Platforms.

Part of this can be optimized by:

  • guarding the code from ICDMonitoringTable against a LIT specific define;

  • disabling LIT specific attributes/commands from ICDM Cluster.

Platform

all

Platform Version(s)

Matter 1.2

Anything else?

No response
@doru91 doru91 added feature work feature request icd Intermittently Connected Devices needs triage labels Sep 8, 2023
@github-actions github-actions bot removed the icd Intermittently Connected Devices label Sep 8, 2023
@bzbarsky-apple bzbarsky-apple added the icd Intermittently Connected Devices label Sep 8, 2023
@bzbarsky-apple bzbarsky-apple added the flash Issues describing flash use improvements label Sep 8, 2023
@bzbarsky-apple
Copy link
Contributor

For a SIT ICD, why is IcdMonitoringTable involved at all? That seems broken. Similar for a bunch of the other things in there...

@woody-apple woody-apple added this to the Future milestone Oct 31, 2023
@kkasperczyk-no kkasperczyk-no self-assigned this Jan 26, 2024
@kkasperczyk-no kkasperczyk-no mentioned this issue Jan 31, 2024
Merged
@mergify mergify bot closed this as completed in #31795 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkasperczyk-no kkasperczyk-no

Labels
feature request feature work flash Issues describing flash use improvements icd Intermittently Connected Devices needs triage
Projects
[Feature] Intermittently Connected Devices (ICD)
Status: Done
[Performance] Flash + RAM usage
Archived in project
[Feature] ICD Phase 2
Status: Todo
Milestone
Future
Development

Successfully merging a pull request may close this issue.

[icd] Introduced gn flags to allow conditional code compilation kkasperczyk-no/connectedhomeip
4 participants
@doru91 @woody-apple @bzbarsky-apple @kkasperczyk-no