Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of operational errors #28891

Closed
bzbarsky-apple opened this issue Aug 25, 2023 · 3 comments · Fixed by #28942
Closed

Incorrect handling of operational errors #28891

bzbarsky-apple opened this issue Aug 25, 2023 · 3 comments · Fixed by #28942

Comments

@bzbarsky-apple
Copy link
Contributor

See #28577 (review)

The immediate issue is the backwards check for "is our error different from the previous one?". But a bigger problem is a clear lack of tests for the functionality....

@bzbarsky-apple
Copy link
Contributor Author

@cjandhyala

@hicklin
Copy link
Contributor

hicklin commented Aug 29, 2023

The lack of test is due to the need of an application that can trigger an error state. We are in the process of building such a device application to allow us to test this and other events and states that are not testable at the moment.

@mergify mergify bot closed this as completed in #28942 Aug 29, 2023
@github-project-automation github-project-automation bot moved this from Open Cert Blockers to Complete in [Certification] Blockers Aug 29, 2023
@bzbarsky-apple
Copy link
Contributor Author

The lack of test is due to the need of an application that can trigger an error state

@hicklin This could be done in all-clusters-app in a YAML test using either a new thing on the UnitTesting cluster or using TestEventTrigger... or maybe adding new YAML functionality to send messages down the pipe all-clusters-app is listening on for triggering its event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants