Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] time sync - remove fabric table delegate on shutdown #28089

Open
cecille opened this issue Jul 19, 2023 · 1 comment
Open

[Feature] time sync - remove fabric table delegate on shutdown #28089

cecille opened this issue Jul 19, 2023 · 1 comment

Comments

@cecille
Copy link
Contributor

cecille commented Jul 19, 2023

Feature description

...
see title, #28011 (comment)

Platform

core

Platform Version(s)

No response

Anything else?

No response

@cecille cecille added feature work feature request needs triage time sync Implementation of the Time Synchronization cluster labels Jul 19, 2023
@github-actions github-actions bot removed the time sync Implementation of the Time Synchronization cluster label Jul 19, 2023
@cecille
Copy link
Contributor Author

cecille commented Aug 23, 2023

The interesting thing here is that we don't have a global shutdown event - we seem to handle removals kind of add-hoc in the server layer, which doesn't work for cluster impls since we're not guaranteed to have them.

Removing this in the destructor is a dodgy proposition because I'm pretty sure that the destructor for statically allocated objects happens after we've de-initialized the memory controller. We could add a shutdown event, but there's a bit of a chicken and egg there for removing platform event handlers. I suppose we could do that in the server code though (global fire sale - everything goes)

@woody-apple woody-apple added this to the 1.2 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants