Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReadHandler] Unify Now timestamps #27920

Closed
lpbeliveau-silabs opened this issue Jul 12, 2023 · 4 comments
Closed

[ReadHandler] Unify Now timestamps #27920

lpbeliveau-silabs opened this issue Jul 12, 2023 · 4 comments

Comments

@lpbeliveau-silabs
Copy link
Contributor

lpbeliveau-silabs commented Jul 12, 2023

In the report Scheduler, we are calling get monotonic timestamp several times in a row to establish a "now" moment. Rework needed so the same timestamp is used instead of consecutive calls to get monotonic timestamp.

@bzbarsky-apple
Copy link
Contributor

The reason this matters: we can get radically different (hundreds of milliseconds apart) values for two consecutive now() calls on Mac/Linux, and the code very much does not expect that to happen as it's written now.

@bzbarsky-apple
Copy link
Contributor

@lpbeliveau-silabs For future reference, links to comments in the "files" view go dead when the code changes... You probably want:

to link to the comments in the main discussion view... (note that the comment ids are the same).

@lpbeliveau-silabs
Copy link
Contributor Author

lpbeliveau-silabs commented Aug 14, 2023

Solved by #28657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants