Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple generated java/jni API from android chip-tool #27398

Closed
yunhanw-google opened this issue Jun 21, 2023 · 1 comment · Fixed by #27624 or #28010
Closed

Decouple generated java/jni API from android chip-tool #27398

yunhanw-google opened this issue Jun 21, 2023 · 1 comment · Fixed by #27624 or #28010
Assignees
Labels
java Issues in java-matter-controller

Comments

@yunhanw-google
Copy link
Contributor

yunhanw-google commented Jun 21, 2023

generated java/jni API for IM is too big, we need to decouple it and fully use the generic java/jni IM API.

The part related to ChipClusters.java is too large, that part was organized by adding a feature. However, in the case of ChipStructs and ChipEventStructs, separate this part into a separate library.
Make CHIPClusterID.jar (Cluster / Attribute / Event / Command ID)
Make CHIPCluster.jar -> ChipStruct.kt, ChipEventStruct.kt

@joonhaengHeo
Copy link
Contributor

@yunhanw-google

I add feature for decoupling generated API.
But, Android Chip-tool can not disable this feature.
Because ChipClusters class is still used in "Cluster Interaction Tool" function.

A complete separation for the completion of this issue requires the following:

  1. Addition of API that can change parameters used for each Command and Write Attribute to TLV.
    (Of course, I know that there is a TLV parse library, but I think I need to find a way to do it without hardcoding as in the example below.)

  1. Added API for TLV Docoding. This fix has been added to the PR.

Any other opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Issues in java-matter-controller
Projects
Archived in project
3 participants