Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0]Darwin: MTRCommissioningParameters for darwin could not skip step sendComplete #26239

Closed
robinmo opened this issue Apr 25, 2023 · 0 comments · Fixed by #26248
Closed

[1.0]Darwin: MTRCommissioningParameters for darwin could not skip step sendComplete #26239

robinmo opened this issue Apr 25, 2023 · 0 comments · Fixed by #26248

Comments

@robinmo
Copy link
Contributor

robinmo commented Apr 25, 2023

Reproduction steps

For darwin there is no way to skip step sendComplete

During commissioning process, as the Matter 1.0 Core Specification, the implementation should provide a way for commissioner to skip step sendComplete.

It says in chapter5.5 Commissioning Flows

While the Administrator of steps 13-15 will, in many situations, be the Commissioner Node itself, it
MAY be a different Node that was configured by the Commissioner to have Administer privilege
against the Commissionee’s General Commissioning Cluster. This is to support flexibility in finalizing the Commissioning. From a Commissionee’s perspective, all Nodes with Administer privilege in
the Commissionee’s ACL are equivalent once the Node has a Node Operational Certificate and associated Node Operational Identifier on the Fabric into which it was just commissioned.

In project connectedhomeip/src/darwin/Framework/CHIP the implementation of MTRDeviceController

- (BOOL)commissionNodeWithID:(NSNumber *)nodeID
         commissioningParams:(MTRCommissioningParameters *)commissioningParams
                       error:(NSError * __autoreleasing *)error;

There is no code to set chip::Controller::CommissioningParameters params SetSkipCommissioningComplete

we try to add a property for MTRCommissioningParameters and set skip sendComplete in

- (BOOL)commissionNodeWithID:(NSNumber *)nodeID
         commissioningParams:(MTRCommissioningParameters *)commissioningParams
                       error:(NSError * __autoreleasing *)error
{
     ...
        if (commissioningParams.skipCommissioningComplete) {
            NSLog(@"Matter step====set skipCommissioningComplete");
            params.SetSkipCommissioningComplete(commissioningParams.skipCommissioningComplete.boolValue);
        }
       ...
}

Could you please provide a skip function just like this or any other way you prefer?

Bug prevalence

Whenever I do this

GitHub hash of the SDK that was being used

9c0ca13 - Fix Linux standalone job. (#23897)

Platform

darwin

Platform Version(s)

iOS 16.2

Type

Platform Issue

Anything else?

No response

@robinmo robinmo changed the title [1.0] MTRCommissioningParameters for darwin could not skip step sendComplete [1.0]Darwin: MTRCommissioningParameters for darwin could not skip step sendComplete Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant