Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RendezvousSession under src/transport #2394

Closed
vivien-apple opened this issue Sep 1, 2020 · 1 comment · Fixed by #2508
Closed

Add RendezvousSession under src/transport #2394

vivien-apple opened this issue Sep 1, 2020 · 1 comment · Fixed by #2508

Comments

@vivien-apple
Copy link
Contributor

Problem

Part of the rendezvous code lives into CHIPDeviceController.cpp and other parts into examples/wifi-echo/server/esp32/main/RendezvousSession.cpp

Some chunks of this code can be moved down into the stack in order to not pollute too much CHIPDeviceController and keep the Pairing mechanism unexposed to the application layer on the device.

Proposed Solution

Move some of the code into src/transport/RendezvousSession.cpp

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants