Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Properly obtain primary WiFi MAC address on Linux #23788

Closed
zqiu-nest opened this issue Nov 29, 2022 · 0 comments · Fixed by #23813
Closed

[Platform] Properly obtain primary WiFi MAC address on Linux #23788

zqiu-nest opened this issue Nov 29, 2022 · 0 comments · Fixed by #23813
Labels

Comments

@zqiu-nest
Copy link
Contributor

Reproduction steps

Currently ConfigurationManagerImpl::GetPrimaryWiFiMACAddress for Linux is only checking address not associated with the loopback interface [1], which doesn't work well for device that have other network interfaces beside WiFi (including virtual network interface that have all 0s for MAC address). Instead we should be able to check for the CHIP_DEVICE_CONFIG_WIFI_STATION_IF_NAME interface [2] to obtain the proper MAC address.

[1]: https://github.com/project-chip/connectedhomeip/blob/master/src/platform/Linux/ConfigurationManagerImpl.cpp#L143
[2]: https://github.com/project-chip/connectedhomeip/blob/master/src/include/platform/CHIPDeviceConfig.h#L357

Platform

other

Platform Version(s)

No response

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants