Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-sve] [TC-DRLK-2.6] set-holiday-schedule results in failure #19912

Closed
mamayorg opened this issue Jun 23, 2022 · 12 comments
Closed

[pre-sve] [TC-DRLK-2.6] set-holiday-schedule results in failure #19912

mamayorg opened this issue Jun 23, 2022 · 12 comments
Assignees

Comments

@mamayorg
Copy link

mamayorg commented Jun 23, 2022

Problem
When trying to set a holiday schedule, the return response is FAILURE.

Command
Commands used
./chip-tool doorlock read number-of-holiday-schedules-supported 1 1
./chip-tool doorlock set-holiday-schedule 1 20 30 0 1 1
./chip-tool doorlock get-holiday-schedule 1 1 1

  • expected behavior : Success response. Return the holiday schedule with the localStarttime and localEndTime as well as operating mode.
  • actual behavior: command gives FAILURE. the get command has missing information

Commit
commit id: 1e3f120
Platform: EFR32
Network: Thread

TC_DRLK_2.6_.txt

@bzbarsky-apple
Copy link
Contributor

Platform: EFR32

@mamayorg What is the server app being used?

@bzbarsky-apple
Copy link
Contributor

@Morozov-5F

@mamayorg
Copy link
Author

Platform: EFR32

@mamayorg What is the server app being used?

I'm using lock-app

@Survensa
Copy link

Survensa commented Jun 29, 2022

@bzbarsky-apple I dont see this issue with RPI

  • Commit used : 81c7f2a
  • Chip-tool : RPI
  • DUT : Door lock app - RPI
  • Network : IP (ethernet)

Full execution log of TC-DRLK-2.6
TC-DRLK-2.6 LOG

@woody-apple
Copy link
Contributor

Cert Blocker Review: @Morozov-5F , can you also take a look at this lock issue? Thanks!

@bzbarsky-apple
Copy link
Contributor

@Survensa which "Door lock app" are you using for DUT? That is, which platform?

@Survensa
Copy link

@Survensa which "Door lock app" are you using for DUT? That is, which platform?

Used RPI for both Chip-tool and DUT with lock app.

@bzbarsky-apple
Copy link
Contributor

OK, so that's the Linux lock app. The original issue is reported with the efr32 lock app, which may have quite different behavior here; a lot of the logic in the lock apps is not shared.

@bzbarsky-apple
Copy link
Contributor

@mykrupp If this is EFR32-specific, could you take a look, please?

@mykrupp
Copy link
Contributor

mykrupp commented Jun 30, 2022

The commit hash tested initially is likely missing parts from EFR32 side and door-lock-server side. I believe the door-lock-server holiday is working now.

This open PR contains schedules implementation on the EFR32 side. I am hoping to get this PR merged before an SVE hash is cut today: #20044

@Morozov-5F
Copy link
Contributor

Seems like this was fixed in the #20044 as it was EFR32-specific. Holiday schedules seem to be working in the lock-app under Linux, can't confirm for EFR32 as I lack the required hardware.

@woody-apple
Copy link
Contributor

Cert Blocker Review: @mamayorg can you please re-verify this, as we believe this is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants