-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write attributes paths are not validated unlike read #19000
Comments
On master as of today, the write does not actually succeed - it returns back an This however isn't presumably the right error. The |
Working on PR now. Should the action abort, or generate a new error: INVALID_PATH? |
@bzbarsky-apple I'm going to recommend we not fix this for v1.0, and defer this, since we don't actually have an issue with spec compliance. |
I have a PR #5425 to check if paths are well-formed, but IDs should not be checked for in-range by the SDK code except if the range is within the MS range. The valid range is to direct new ID allocation, not for operational checks. We may expand or reduce the range in the future. If the SDK does not recognize an ID (in or outside the current range), then that is enough. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This stale issue has been automatically closed. Thank you for your contributions. |
Fixed by #29461 |
Problem
./chip-tool any read-by-id 0x11110001 0x1111f001 1 1
fails with INVALID_ACTION but./chip-tool any write-by-id 0x11110001 0x1111f001 "abc" 1 1
succeeds.This is concerning the valid range for cluster id and attribute id.
Proposed Solution
Do we need to have this check?
The text was updated successfully, but these errors were encountered: