Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequiredPrivilege should replace weak functions with another mechanism #16540

Closed
mlepage-google opened this issue Mar 22, 2022 · 2 comments
Closed
Labels
acl Access Control feature stale Stale issue or PR

Comments

@mlepage-google
Copy link
Contributor

PR #16327 introduced weak functions MatterGetAccessPrivilegeForReadAttribute (and WriteAttribute, InvokeCommand, ReadEvent).

This is because RequiredPrivilege is built into the DM/IM library, but the underlying data is built per app/example.

Ideally we would have a better mechanism that would not rely upon weak functions, since they can be cumbersome and error prone to ensure the correct ones are linked. We don't want to inadvertently have an artifact using an unexpected implementation of those functions, since they are used to check access control for DM/IM operations.

Probably we should have a "provider" interface and then the artifact can install/configure it at startup.

@stale
Copy link

stale bot commented Sep 20, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Sep 20, 2022
@stale
Copy link

stale bot commented Sep 27, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acl Access Control feature stale Stale issue or PR
Projects
None yet
Development

No branches or pull requests

1 participant