Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device commissioner requires ICAC when it should be optional #16248

Closed
cecille opened this issue Mar 15, 2022 · 0 comments · Fixed by #16879
Closed

Device commissioner requires ICAC when it should be optional #16248

cecille opened this issue Mar 15, 2022 · 0 comments · Fixed by #16879
Assignees
@cecille
Labels
commissioning Involves placing devices on the network, initial setup

Comments

@cecille
Copy link
Contributor

cecille commented Mar 15, 2022

Problem

Device commissioner incorrectly enforces that the ICAC needs to be present.

Proposed Solution

Remove the check in and pass through the optional value to the underlying function.
@cecille cecille self-assigned this Mar 15, 2022
@cecille cecille added the commissioning Involves placing devices on the network, initial setup label Mar 15, 2022
@cecille cecille mentioned this issue Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cecille cecille

Labels
commissioning Involves placing devices on the network, initial setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ICAC should be optional cecille/connectedhomeip
1 participant
@cecille