Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLEEndPoint possible refcount overflow #15579

Closed
andyp-apple opened this issue Feb 25, 2022 · 1 comment · Fixed by #16046
Closed

BLEEndPoint possible refcount overflow #15579

andyp-apple opened this issue Feb 25, 2022 · 1 comment · Fixed by #16046
Assignees
@lzgrablic02
Labels
security V1.0

Comments

@andyp-apple
Copy link

mRefCount should be checked for overflow before incrementing

connectedhomeip/src/ble/BLEEndPoint.h

Line 117 in 980e177

void AddRef() { mRefCount++; }

@lzgrablic02 lzgrablic02 self-assigned this Mar 10, 2022
@lzgrablic02 lzgrablic02 mentioned this issue Mar 10, 2022
Merged
@lzgrablic02
Copy link
Contributor

It doesn't look like AddRef() is even called. Is it still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzgrablic02 lzgrablic02

Labels
security V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BLEEndPoint ref count overflow check lzgrablic02/connectedhomeip
3 participants
@lzgrablic02 @woody-apple @andyp-apple