Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No commissioner handling for discriminator collisions #13657

Closed
msandstedt opened this issue Jan 18, 2022 · 3 comments
Closed

No commissioner handling for discriminator collisions #13657

msandstedt opened this issue Jan 18, 2022 · 3 comments
Labels
stale Stale issue or PR V1.X

Comments

@msandstedt
Copy link
Contributor

Problem

Commissionable node discriminators are 12-bit, meaning that collisions will occur and must be handled. Certainty in location of the intended commissionee depends upon successful PASE connection, as this verifies that both peers hold the same shared secret.

Proposed Solution

A plausible discovery algorithm could collect discovered commisisonee candidates with matching discriminators, and then try PASE to each in turn. This algorithm is also easily extended to attempting connection via more than one resolved IP address for a given candidate.

The proposed design in #13294 does both of these things.

@msandstedt
Copy link
Contributor Author

CC @cecille , @tcarmelveilleux , @pan-apple

@stale
Copy link

stale bot commented Jul 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale Stale issue or PR label Jul 21, 2022
@stale
Copy link

stale bot commented Oct 18, 2022

This stale issue has been automatically closed. Thank you for your contributions.

@stale stale bot closed this as completed Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issue or PR V1.X
Projects
None yet
Development

No branches or pull requests

2 participants