Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HandleGetInputList API is not implementable without memory-safety errors #13375

Closed
bzbarsky-apple opened this issue Jan 7, 2022 · 2 comments
Closed
Assignees
Labels

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

This API asks the callee to return a list of structs. Those structs contains CharSpan instances, but there is nowhere to store the data those CharSpans point to, and no way to know when it's safe to free it. This means the API cannot be implemented without either leaks or use-after-free, or both.

Proposed Solution

Fix the API to be implementable without leaks or security bugs.

@chrisdecenzo @lazarkov @xylophone21

@bzbarsky-apple
Copy link
Contributor Author

This API was added in #13259

@lazarkov
Copy link
Contributor

lazarkov commented Feb 7, 2022

This one should be fixed now. @bzbarsky-apple
If not please re-open.

@lazarkov lazarkov closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants