TargetVideoPlayerInfo::Initialize assumes that CASE connection is synchronous

[sharadb-amazon]

Problem

FindSecureSessionForNode() is being used for legacy tests which use nodeId to send packets and for the tv-casting-app that uses the TV's node ID to find the associated secure session. It is based on using NodeId to locate the SecureSession.
Instead use FindOrEstablishSession()

Complete by by 12/31

Proposed Solution

Get this fixed by making changes to the CHIPDeviceCommissioner
Look into DnssdServer::AdvertiseOperational()
When creating a fabric and a nodeId for itself when commissioning another device, make sure that those get picked up by DnssdServer

[bzbarsky-apple]

In #17266 this code was updated to no longer use back-door APIs, but now it's assuming sync callbacks from an operation that might be async (CASE establishment).

[bzbarsky-apple]

That said, this is a problem for this specific example; it's not a spec issue or an app cluster issue.

[chrisdecenzo]

This issue no longer exists (and the latest code does not have a sync callback dependence), so this can be closed

[bzbarsky-apple]

The sync behavior is still there; it's just moved to TargetVideoPlayerInfo::Initialize

[chrisdecenzo]

ok, the Initialization returns an error in the async case but the callback correctly completes the init. This code could be cleaned up but this is not a launch blocker.

[bzbarsky-apple]

but this is not a launch blocker

Agreed; hence the label changes above.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.