Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is broken! If something under here returns error, we will try #12436

Closed
todo bot opened this issue Dec 1, 2021 · 0 comments
Closed

This is broken! If something under here returns error, we will try #12436

todo bot opened this issue Dec 1, 2021 · 0 comments
Assignees
Labels

Comments

@todo
Copy link

todo bot commented Dec 1, 2021

// TODO: This is broken! If something under here returns error, we will try
// to SendCommandResponse(), and then our caller will try to send a status
// response too. Figure out at what point it's our responsibility to
// handler errors vs our caller's.
Handle workHandle(this);
mpExchangeCtx->WillSendMessage();
ReturnErrorOnFailure(ProcessInvokeRequest(std::move(payload), isTimedInvoke));
return CHIP_NO_ERROR;
}


This issue was generated by todo based on a TODO comment in bd94a78 when #12389 was merged. cc @bzbarsky-apple.
@todo todo bot added the todo label Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants