You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We only have an example implementation of the GroupDataProvider. We need to have at least one basic implementation that allows trial decryption of incoming group message and encryption of group message. This implementation can and should be overridden to allow the use of platform specific cryptographic api.
Proposed Solution
Convert the GroupDataProvider class from pure virtual to virtual class as to provide a common implementation of its feature.
StaticGroupsProvider::Decrypt should take the PacketHeader as a const reference, not by value.
StaticGroupsProvider::Decrypt should almost certainly take the PacketBufferHandle as an lvalue reference, not an rvalue reference, since it's not taking ownership of the buffer, I assume.
The text was updated successfully, but these errors were encountered:
Problem
We only have an example implementation of the
GroupDataProvider
. We need to have at least one basic implementation that allows trial decryption of incoming group message and encryption of group message. This implementation can and should be overridden to allow the use of platform specific cryptographic api.Proposed Solution
Convert the
GroupDataProvider
class from pure virtual to virtual class as to provide a common implementation of its feature.Related issues :
While doing so please apply @bzbarsky-apple comments for PR #10985 :
The text was updated successfully, but these errors were encountered: