Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the GroupDataProvider #11075

Closed
jepenven-silabs opened this issue Oct 27, 2021 · 0 comments · Fixed by #12047
Closed

Implement the GroupDataProvider #11075

jepenven-silabs opened this issue Oct 27, 2021 · 0 comments · Fixed by #12047

Comments

@jepenven-silabs
Copy link
Contributor

jepenven-silabs commented Oct 27, 2021

Problem

We only have an example implementation of the GroupDataProvider. We need to have at least one basic implementation that allows trial decryption of incoming group message and encryption of group message. This implementation can and should be overridden to allow the use of platform specific cryptographic api.

Proposed Solution

Convert the GroupDataProvider class from pure virtual to virtual class as to provide a common implementation of its feature.

Related issues :

While doing so please apply @bzbarsky-apple comments for PR #10985 :

  • StaticGroupsProvider::Decrypt should take the PacketHeader as a const reference, not by value.
  • StaticGroupsProvider::Decrypt should almost certainly take the PacketBufferHandle as an lvalue reference, not an rvalue reference, since it's not taking ownership of the buffer, I assume.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants