Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-TSUIC-2.2] Test steps 2C, 3G and 4C Validation Failing. #11052

Closed
kvikrambhat opened this issue Oct 27, 2021 · 8 comments
Closed

[TC-TSUIC-2.2] Test steps 2C, 3G and 4C Validation Failing. #11052

kvikrambhat opened this issue Oct 27, 2021 · 8 comments
Labels
cert spec Mismatch between spec and implementation V1.0

Comments

@kvikrambhat
Copy link
Contributor

Problem

Validation for the following test steps are failing

  • TH writes a value of greater than 1 TemperatureDisplayMode attribute of DUT
  • TH writes a value of greater than 5 to KeypadLockout attribute of DUT
  • TH writes a value of greater than 1 to ScheduleProgrammingVisibility attribute of DUT
    In all these test steps, the DUT should return an error CONSTRAINT_ERROR (0x87), however the cluster apps are successfully writing values greater than specified into the respective attributes.

Attached logs from YAML test script for reference.
TC_TSUIC_2_2_Failures.txt

@yufengwangca
Copy link
Contributor

It looks we are missing the constraint for those attributes

@yufengwangca yufengwangca self-assigned this Feb 2, 2022
@woody-apple woody-apple added the spec Mismatch between spec and implementation label Feb 8, 2022
@yufengwangca
Copy link
Contributor

yufengwangca commented Feb 15, 2022

These attributes seems silab proprietary and I couldn't find them in spec. The SDK definition for those values are in
src/app/zap-templates/zcl/data-model/silabs/types.xml

@kvikrambhat
What is the range definition for those attribute?

@yufengwangca yufengwangca assigned ghost and unassigned yufengwangca Feb 15, 2022
@yufengwangca
Copy link
Contributor

@eve-cxrp

I though this issue should be addressed by #11058, could you confirm?

@ghost
Copy link

ghost commented Feb 15, 2022

@yufengwangca Yes this is fixed by the issue. As you can see here the function is added to the endpoint_config.h and is called then.

We have encountered a similar problem which is caused by a compiler bug. There was also a slack discussion related to this.

The discussion started here and the relevant findings are here

@yufengwangca
Copy link
Contributor

@eve-cxrp

Where is the xml definition for ThermostatUserInterfaceConfiguration cluster? I only see the server callback in our SDK

@ghost
Copy link

ghost commented Feb 16, 2022

@eve-cxrp

Where is the xml definition for ThermostatUserInterfaceConfiguration cluster? I only see the server callback in our SDK

Here

@bzbarsky-apple
Copy link
Contributor

Fixed in #12325

@bzbarsky-apple
Copy link
Contributor

@kvikrambhat That said, I do not see any (even disabled) YAML tests trying to exercise this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cert spec Mismatch between spec and implementation V1.0
Projects
None yet
Development

No branches or pull requests

5 participants