Add log for decryption failure (#14970)

project-chip · Feb 9, 2022 · 98d1e33 · 98d1e33
1 parent 1744422
commit 98d1e33
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/transport/SessionManager.cpp b/src/transport/SessionManager.cpp
@@ -624,7 +624,11 @@ void SessionManager::SecureGroupMessageDispatch(const PacketHeader & packetHeade
     // Trial decryption with GroupDataProvider
     Credentials::GroupDataProvider::GroupSession groupContext;
     auto iter = groups->IterateGroupSessions(packetHeader.GetSessionId());
-    VerifyOrReturn(nullptr != iter);
+    if (iter == nullptr)
+    {
+        ChipLogError(Inet, "Failed to retrieve Groups iterator. Discarding everything");
+        return;
+    }
 
     System::PacketBufferHandle msgCopy;
     bool decrypted = false;
@@ -635,7 +639,11 @@ void SessionManager::SecureGroupMessageDispatch(const PacketHeader & packetHeade
             (CHIP_NO_ERROR == SecureMessageCodec::Decrypt(CryptoContext(groupContext.key), payloadHeader, packetHeader, msgCopy));
     }
     iter->Release();
-    VerifyOrReturn(decrypted);
+    if (!decrypted)
+    {
+        ChipLogError(Inet, "Failed to retrieve Key. Discarding everything");
+        return;
+    }
     msg = std::move(msgCopy);
 
     // MCSP check