-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix chip-tool storage ifdefs to make more sense. (#29388)
A few fixes here: 1) CONFIG_USE_LOCAL_STORAGE was being defined to 0 when config_use_local_storage was false, but the tests for it use #ifdef, so setting config_use_local_storage to false did not work right. 2) Commands.cpp was using config options from CHIPDeviceConfig.h without explicitly including it. It happened to be pulled in by KeyValueStoreManager.h, but better to not depend on it. 3) The UseStorageDirectory bits dependency on CHIP_DISABLE_PLATFORM_KVS was set up such that if it was true we ended up with an unused PersistedStorage::KeyValueStoreMgrImpl() return value. This got optimized out in optimized builds, so things worked, but in debug builds we would get link errors. 4) Several Darwin CI jobs that were trying to build the Debug configuraion actually built the Release one, because they did not specify a configuration and that defaults to Release. 5) Remove the unnecessary CHIP_DISABLE_PLATFORM_KVS bits from the Xcode project.
- Loading branch information
1 parent
6c7b7c0
commit 4152547
Showing
5 changed files
with
13 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters