From 350d49bf58ab2c6fc3aa04f9ae9c48d658e99965 Mon Sep 17 00:00:00 2001 From: Arkadiusz Bokowy Date: Mon, 8 May 2023 16:46:17 +0200 Subject: [PATCH] Do not use getenv() in Tizen GN config (#26411) Using getenv is discouraged, because it will get the value from the environment of the build system only on first use. Any environment changes after that will not be reflected in the build. --- build/config/tizen/config.gni | 4 ++-- src/test_driver/tizen/README.md | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/build/config/tizen/config.gni b/build/config/tizen/config.gni index 06a03d59b86881..84891db9545d57 100644 --- a/build/config/tizen/config.gni +++ b/build/config/tizen/config.gni @@ -14,8 +14,8 @@ declare_args() { # Location of Tizen SDK - tizen_sdk_root = getenv("TIZEN_SDK_ROOT") + tizen_sdk_root = "" # Location of Tizen SDK sysroot - tizen_sdk_sysroot = getenv("TIZEN_SDK_SYSROOT") + tizen_sdk_sysroot = "" } diff --git a/src/test_driver/tizen/README.md b/src/test_driver/tizen/README.md index b4e8ed39ad5312..85a91563183b42 100644 --- a/src/test_driver/tizen/README.md +++ b/src/test_driver/tizen/README.md @@ -47,7 +47,10 @@ argument of the `gn gen` command. # Generate test target gn gen --check --fail-on-unused-args \ --root="$PWD/src/test_driver/tizen" \ - --args="target_os=\"tizen\" target_cpu=\"arm\" chip_config_network_layer_ble=false" \ + --args="target_os=\"tizen\" target_cpu=\"arm\" \ + tizen_sdk_root=\"$TIZEN_SDK_ROOT\" \ + tizen_sdk_sysroot=\"$TIZEN_SDK_SYSROOT\" + chip_config_network_layer_ble=false" \ out/tizen-check # Run Tizen QEMU-based tests ninja -C out/tizen-check check