Best-effort flush events at shutdown (#15331)

project-chip · Feb 22, 2022 · 2049505 · 2049505
1 parent d3c3147
commit 2049505
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/app/reporting/Engine.cpp b/src/app/reporting/Engine.cpp
@@ -42,6 +42,9 @@ CHIP_ERROR Engine::Init()
 
 void Engine::Shutdown()
 {
+    // Flush out the event buffer synchronously
+    ScheduleUrgentEventDeliverySync();
+
     mNumReportsInFlight = 0;
     mCurReadHandlerIdx  = 0;
     mGlobalDirtySet.ReleaseAll();
@@ -746,6 +749,22 @@ CHIP_ERROR Engine::ScheduleEventDelivery(ConcreteEventPath & aPath, EventOptions
     return CHIP_NO_ERROR;
 }
 
+void Engine::ScheduleUrgentEventDeliverySync()
+{
+    InteractionModelEngine::GetInstance()->mReadHandlers.ForEachActiveObject([](ReadHandler * handler) {
+        if (handler->IsType(ReadHandler::InteractionType::Read))
+        {
+            return Loop::Continue;
+        }
+
+        handler->UnblockUrgentEventDelivery();
+
+        return Loop::Continue;
+    });
+
+    Run();
+}
+
 }; // namespace reporting
 } // namespace app
 } // namespace chip

diff --git a/src/app/reporting/Engine.h b/src/app/reporting/Engine.h
@@ -146,6 +146,7 @@ class Engine
     CHIP_ERROR ScheduleUrgentEventDelivery(ConcreteEventPath & aPath);
     CHIP_ERROR ScheduleBufferPressureEventDelivery(uint32_t aBytesWritten);
     void GetMinEventLogPosition(uint32_t & aMinLogPosition);
+    void ScheduleUrgentEventDeliverySync();
 
     /**
      * If the provided path is a superset of our of our existing paths, update that existing path to match the