From 1574e205f4dec65b4bb0631f31617cf6321ef69e Mon Sep 17 00:00:00 2001 From: Sharad Binjola Date: Wed, 26 Jul 2023 13:21:53 -0700 Subject: [PATCH] Addressing feedback from bzbarsky-apple@ --- src/app/server/AppDelegate.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/app/server/AppDelegate.h b/src/app/server/AppDelegate.h index 56c4587f66139e..91a5f60893e4da 100644 --- a/src/app/server/AppDelegate.h +++ b/src/app/server/AppDelegate.h @@ -39,14 +39,17 @@ class AppDelegate virtual void OnCommissioningSessionStarted() {} /** - * This is called when there is an error in establishing a commissioning session (such as, when an invalid passcode is provided) + * This is called when the PASE establishment failed (such as, when an invalid passcode is provided) or PASE was established + * fine but then the fail-safe expired (including being expired by the commissioner) * * @param err CHIP_ERROR indicating the error that occurred during session establishment */ virtual void OnCommissioningSessionEstablishmentError(CHIP_ERROR err) {} /** - * This is called when the commissioning session establishment stops + * This is called when the PASE establishment failed or PASE was established fine but then the fail-safe expired (including + * being expired by the commissioner) AND the commissioning window is closed. The window may be closed because the commissioning + * attempts limit was reached or advertising/listening for PASE failed. */ virtual void OnCommissioningSessionStopped() {}