Helm: Update job ttl to make it configurable #695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the ability to set non-zero value for
.spec.ttlSecondsAfterFinished
field of webhook Jobs. It is needed because some CD tools (eg. ArgoCD) are not able to get the status of the completed Job before it is cleaned up and hangs at syncing status. By setting ttlSecondsAfterFinished value to non-zero (eg.10
seconds), it gives ArgoCD enough time to get the status of the job and complete sync operation.This change does not break or change existing functionality. It add the ability to change ttlSecondsAfterFinished if required.
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)