-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure cargo tarpaulin
is using same Rust version as Akri
#501
Comments
I'll take this one, I'll try to see if we can set the env var itself and worst case we can update rust and move forward for now. |
i wonder if you couldn't do something like this:
|
seems to work. i created this PR: #503 ... when i cherry-picked the changes onto #498, the tarpaulin run succeeded: https://github.com/project-akri/akri/runs/8102394108?check_suite_focus=true |
Thanks Brian! |
Describe the bug
Akri's code coverage checks with
cargo tarpaulin
are currently failing becausecargo tarpaulin
is using the1.63
rust toolchain while Akri is using1.61
.cargo tarpaulin
should be inferring Rust version from the Cargo.toml. However, instead of checking each package'sCargo.toml
(see the agent's) and installing and using a potentially different toolchain for each, it may just be checking the baseCargo.toml
. However, since our base toml represents the larger workspace of projects, it cannot specify a version, so it appears that tarpaulin just uses latest stable in this case.Investigation should be done as to whether the
CARGO_PACKAGE_VERSION
env var can be explicitly set to a specific rust version in the workflow when running tarpaulin in a container.The text was updated successfully, but these errors were encountered: