Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sliding window attention bug? #7

Open
sustcsonglin opened this issue May 15, 2024 · 0 comments
Open

sliding window attention bug? #7

sustcsonglin opened this issue May 15, 2024 · 0 comments

Comments

@sustcsonglin
Copy link

Hello Volodymyr,

I noticed that at this line, the window_size passed to flash_attn_func is (-window_size, 0). From my tests, this configuration effectively implements global attention rather than sliding window attention. I believe the correct implementation should resemble the one found in Mistral.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sustcsonglin