src: define URLHost::Reset() function

Fixes: nodejs#18302
prog1dev · Jan 23, 2018 · bd831b4 · bd831b4
1 parent 63f78f5
commit bd831b4
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -92,6 +92,15 @@ class URLHost {
   Value value_;
   HostType type_ = HostType::H_FAILED;
 
+  inline void Reset() {
+    using string = std::string;
+    switch (type_) {
+      case HostType::H_DOMAIN: value_.domain.~string(); break;
+      case HostType::H_OPAQUE: value_.opaque.~string(); break;
+      default: break;
+    }
+  }
+
   // Setting the string members of the union with = is brittle because
   // it relies on them being initialized to a state that requires no
   // destruction of old data.
@@ -112,12 +121,7 @@ class URLHost {
 };
 
 URLHost::~URLHost() {
-  using string = std::string;
-  switch (type_) {
-    case HostType::H_DOMAIN: value_.domain.~string(); break;
-    case HostType::H_OPAQUE: value_.opaque.~string(); break;
-    default: break;
-  }
+  Reset();
 }
 
 #define ARGS(XX)                                                              \