Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the code #35

Open
Lionel-dev opened this issue Feb 21, 2024 · 2 comments
Open

Simplify the code #35

Lionel-dev opened this issue Feb 21, 2024 · 2 comments

Comments

@Lionel-dev
Copy link

Hi !

I've just reworked a TSX file, simplifying it, following certain code conventions and re-naming certain variables/functions.

Here are my commits. To avoid spamming you, would you like me to take a closer look?

49c66c9
57ecec6

Thank you for this interesting project

@salilponde
Copy link
Contributor

Hi @Lionel-dev thanks for your interest in the project. Currently the project GitHub workflow is not setup properly for collaboration as I was the sole developer for this project until now. So before accepting PRs, the workflow will have to be improved, like creating a dev branch and accepting PRs on dev branch instead of main branch. If anything is merged to main it triggers a build and pushes an image to the Docker hub, so it needs to be tested properly and the version number in a few files need to be updated. The versioning logic is a bit messy - need to update the version number at 3 places. So that needs to be improved too.

I am currently not spending time on this project due to other priorities. If you are interested in contributing you (or someone else) will have to first fix the development workflow then send PRs to the development branch. So I would advise that your maintain a fork for a while and if you are able to successfully maintain it, I will give you rights to this repository.

@Lionel-dev
Copy link
Author

Thanks for all this information, as you can see, I have a fork with fairly "simple" modifications, mainly of the re factor in fact.

So I can continue on this and make myself a main environment with clean branches?

I'm looking internally with my boss to see if we can allocate time/budget to this project and get back to you via discord if you want!

In any case, I think you've got a beautiful baby with this project, you stand out in a very good UI and management by nodes which allows people who need to isolate their customers in a node to have much simpler!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants