Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

V2 #446

Merged
merged 7 commits into from
Aug 2, 2020
Merged

V2 #446

merged 7 commits into from
Aug 2, 2020

Conversation

MichaelDvP
Copy link
Collaborator

Here are my changes, i've split in different commits.

I have changed the mqtt custom-format for the thermostat to single, this is more in line with mixer. (Don't know if someone else but me uses it).

The devices&sensors page doesn't show me the Warm Water current temperature (also missing in your screenshot) and not all 7 sensors, i've enlarged the buffer a bit.

With esp32 the sensors sometimes have blackouts and not all are readout. Without the yield it seems to be a bit better, but not realy good. I'm thinking about remember the number of sensors and if a new readout gives less sensors, retry up to 3 times before updating. What do you think?

@proddy
Copy link
Collaborator

proddy commented Aug 1, 2020

great fixes, thanks. I'll test and then merge.

For the sensors on the ESP32 perhaps there is a better library than the old 1-wire for ESP8266. Try this one https://github.com/stickbreaker/OneWire which is optimized for the ESP32. See the authors comments at espressif/arduino-esp32#1335 (comment).

@MichaelDvP
Copy link
Collaborator Author

Thanks, the stickbreaker lib is based on an older version, i've only added the IRAM_ATTR to reset, write_bitand read_bit for ESP32 and it's much better, but i also added a retry if sensornumber decreases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants