Refactor out preproc.issue #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the preproc.issue package by relocating supporting classes for PreprocessIssueMessageSimplifier and PdeIssueEmitter as inner classes. This assists with #10.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the
preproc.issuepackage by relocating supporting classes forPreprocessIssueMessageSimplifierandPdeIssueEmitteras inner classes. This assists with #10. Real fast...PdeIssueEmitteris required for ANTLR. It isn't new... it's from the ANTLR migration about a year ago.PreprocessIssueMessageSimplifierisn't new (I wrote it about a year ago to support the new ANTLR migration) but to briefly describe: without help ANTLR's messages emitted by default are pretty difficult to understand unless you are fairly familiar with ANTLR. This class interprets the messages emitted by ANTLR to create better (more user friendly?) error messages. However, even when the "right" message to show to the user is found, the work isn't quite done. The message has to be localized to user language and sometimes the location of the error has to be modified. All of this logic is currently in here.