Fix display density detection and use GraphicsConfiguration. #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflexive access is no longer allowed so we need to transition displayDensity and isRetina to GraphicsConfiguration. As part of this, it's worth noting that other displays outside of OS X may have a retina-like display.
|
Tested on Windows 10 and Ubuntu 18.04.1 (both show displayDensity of 1). Also checked PGraphics across all OS. https://gist.github.com/sampottinger/36ca3e3c57f510380b8be597c95f1eb8. Mac reports displayDensity of 2 on my retina screen. |
sampottinger
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflexive access is no longer allowed so we need to transition displayDensity and isRetina to GraphicsConfiguration. Note that I am letting the cross-platform interface work on its own without the operating system check but, in testing, I have only seen a scale == 1 on Windows and Linux.
Resolves #32 and resolves #35.