Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert int after color instead of before to allow visibility modifier. #105

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

sampottinger
Copy link
Collaborator

During ANTLR traversal, insert int after color instead of before. This allows visibility modifier (like public) to get inserted at the correct spot (prevents int public). Resolves #104.

@sampottinger sampottinger requested a review from benfry June 29, 2020 22:20
@sampottinger
Copy link
Collaborator Author

This is available on an integration branch at https://github.com/sampottinger/processing4 (master) for testing in the context of other open PRs with a community build at https://www.datadrivenempathy.com/processing.

@benfry benfry merged commit 6d8fa34 into master Aug 15, 2020
@benfry benfry deleted the fix_color_return branch August 15, 2020 12:57
@github-actions
Copy link

This pull request has been automatically locked. Pull requests that have been closed are automatically locked 30 days after the last comment.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color as return type is broken
2 participants