Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd spacing in preprocessor-generated code #136

Closed
benfry opened this issue Sep 25, 2020 · 3 comments · Fixed by #138
Closed

Odd spacing in preprocessor-generated code #136

benfry opened this issue Sep 25, 2020 · 3 comments · Fixed by #138
Assignees

Comments

@benfry
Copy link
Owner

benfry commented Sep 25, 2020

Looks like the rewritten size() command that's generated by the preprocessor doesn't follow our guidelines for whitespace (i.e. before parens, etc) per the rest of the examples or our online guidelines in the wiki. In the past, I believe we just grabbed the size() command and dropped it back in as-is, but at a minimum it should have a single space after each parameter. Not sure if there are other things like this from the preproc as well.

@sampottinger
Copy link
Collaborator

Ah dang sorry just saw this. Quick fix and my bad... I don't think "rewrites" like this happen elsewhere. Fixed in #138

@benfry
Copy link
Owner Author

benfry commented Sep 25, 2020

Great; thanks!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants