Feat: #445/#446 generate .pdez files for each code example #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefterv
requested changes
Jul 12, 2024
There was a problem hiding this comment.
Hi umangutkarsh,
Thank you for your contribution. I've taken a look and it looks like your script does not generate valid PDEZ files. PDEZ Files are zip files containing the sketches, not JSON with metadata
Here's an example of a PDEZ file by @SableRaf https://sableraf.github.io/testURIscheme/sketchBundle.pdez
Also there was request to add this functionality to the existing updateExamples.js file instead of creating a new one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #445
Fixes #446
To create the
updatePdezFiles.jsscript for updating.pdezfiles based on the provided information, and thegeneratePdezContent()function, the followiing code can be used. This script iterates through the examples, generates.pdezcontent using thegeneratePdezContent()function, and writes the content to the corresponding.pdezfiles.The script assumes that you have a directory structure with
.pdefiles and that thegeneratePdezContentfunction generates the.pdezcontent based on the provided example data. You can modify thegeneratePdezContentfunction to customize the content as needed.Make sure to adjust the paths and update the
generatePdezContentfunction to match your specific requirements for generating.pdezfiles.