-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[p5.js 2.0 RFC Proposal]: Functional core and modular build #7014
Comments
I think modularisation would be a huge benefit to v2 but I worry about the approach of It is a drastic change but I would rather see something like the example below, as it is (1) tree-shakeable, (2) does not require referencing or polluting a single import p5 from 'p5';
import * as math from 'p5/math.js';
// The same instance mode syntax
const sketch = (p => {
p.setup = () => {
p.createCanvas(400, 400);
console.log(math.ceil(2.1)); // math is being used directly
};
p.draw = () => {
p.background(200);
p.circle(200, 200, 100);
};
});
new p5(sketch); |
@mattdesl The current idea I have may end up supporting both cases actually, at least for some modules. If #6830 is implemented, there should not be a big difference between directly importing say the math module and using it with p5.js here, and using the math module externally without p5.js. Some modules may still need to be explicitly linked to The |
I agree with @mattdesl. Modules shouldn't use the same system as libraries, it's clunky and too much boilerplate code. I think Modules should be conceptually separate from libraries. Modules should just simply add functionality to p5, they don't need to use the method hooks that libraries do. Consider that even the named import syntax is intimidating for beginners and explaining it requires they already know how objects work. import * as math from 'p5/math.js'; Even though having imports be loaded through side effects is frowned upon by professional devs, perhaps it'd be best if p5 modules were just added to p5 behind the scenes to keep things simple on the user end. import 'p5/math.js'; Modules could just be added like this: p5.modules.math = function (p5Instance) {
// add math functions here
}; And p5.js would load them like this: for (let module of modules) {
module(this);
} That way p5.js could be compatible with q5.js modules. What do you think? @limzykenneth |
Are you mostly referring to the boilerplate for library devs or for the end user?
To add some context for the current rationale for this, it's about making it easy to add core-like features in third party addons. This would mean people aren't blocked on GitHub review if they want to try out building a feature that they want to work like a core feature (e.g. building something like an SVG renderer), and it'd make it easy for us to package it along with core builds later on. Maybe not the most standard thing to optimize for, but something based on our current bottlenecks. This isn't set in stone yet of course.
I think that's kind of how the proposal mentions the core modules are getting loaded right now in
This is kinda similar to what the proposal is describing I think. Starting from your idea, it looks like the current proposal makes these changes:
|
@davepagurek ah okay I missed that part. I can see how @limzykenneth's import * as mathModuleFn from 'p5/math.js';
let MyMath = {};
mathModuleFn(MyMath, MyMath.prototype);
let math = new MyMath(); Only then would
In limzy's user code, the Modules that just add functionality to a p5 instance could hypothetically be loaded when the sketch actually needs the module's features. I'm not sold on the real world purpose for providing this but it'd be easier for users this way. edit: Also overriding p5 methods could be done on an instance basis. // p5/math.js
if (typeof p5 == undefined) p5 = { modules: {} };
p5.modules.math = function (p5Instance) {
p5Instance ??= {};
// ...
return p5Instance;
} let math = p5.modules.math();
I imagine that some modules will depend on others being loaded. A module could also provide altered functionality depending on which modules are loaded. Having all the modules be added to |
Increasing access
p5.js as a library is mostly about the easy to use syntax to enable drawing onto a virtual canvas that it provides its users, the underlying implementation can and should change depending on what the specific needs of the environment are. With a functional core that additional modules can be attached onto, p5.js can be made maximally flexible across environment and diverse user needs.
Which types of changes would be made?
Most appropriate sub-area of p5.js?
What's the problem?
The way p5.js is currently split into modules utilizes ES6 modules side-effect imports which on the one hand is not very semantic, and on the other hand more significantly, different modules depends on each other to a large extent, making it hard to exclude certain module where it should not have been needed.
The current build of p5.js library files are also very big. Being able to modularize the build to not include features the user may not need can reduce file size significantly.
What's the solution?
p5.js will have a core that contains only the absolute essential functionalities, while all other code will be separately import-able. Take as example the core only build of p5.js and the math module as a separate module not included in core, two versions of each will be built from the source code: IIFE and ESM. Rollup is setup to create build for both with IIFE being the preferred format for most users using
<script>
tags and ESM the preferred format for users using their own bundlers. (CommonJS or AMD format will not be supported)IIFE
Immediately Invoked Function Expression (IIFE) is a common format libraries meant to be included with regular
<script>
tag will come in. It prevents excessive global namespace pollution and is also used by p5.js 1.0. Rollup have several output formats and libraries meant to be included with regular<script>
tag will either be usingiife
orumd
, the later of which combines IIFE, CommonJS, and RequireJS/AMD module syntax in one. p5.js 2.0 will mainly use Rollup'siife
format as IIFE allows for initialization through just side effects while for UMD, an export name must be set which is not compatible with the IIFE usage we want.In the above example, both
p5.js
andp5.math.js
are built with theiife
format. This usage is similar if not identical to the usage of addon libraries currently (deliberately so). Themath
module here is a bundled module taken from all the source located insrc/math
folder. Each file in that folder can be independenly built into theiife
format with Rollup if desired and the whole module can be included in the finalp5.js
bundle if desired as well.Please see relevant examples in the exploration fork for implementation.
ESM
ESM or ES Module is the current standard in JavaScript for working with modular JavaScript code. ESM are now very widely supported with all major browsers natively supporting it, all modern build tools supports or are even built around it, and Node.js have native support for it as well. p5.js 1.0's code is already written with ESM and transpiled into a UMD module. As part of the refactor mentioned in a previos section, the syntax of the internal use of ESM will be updated to match semantic usage. The main goal will be to limit cross dependencies between modules and minimize the use of side effects imports.
The above example assumes the user is using Node.js module resolution and have installed
p5
through NPM. However, distributable ESM modules are built and will be published via CDN as well. To use this, the first two lines will instead be:The
registerAddon
static method is further described in the library proposal and represent a unified way that internal module and third party library extends the functionalities of the p5.js core.Pros (updated based on community comments)
Cons (updated based on community comments)
Proposal status
Under review
The text was updated successfully, but these errors were encountered: