Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated wiki for Global and instance mode #1844

Closed
montoyamoraga opened this issue Mar 6, 2017 · 17 comments
Closed

Outdated wiki for Global and instance mode #1844

montoyamoraga opened this issue Mar 6, 2017 · 17 comments

Comments

@montoyamoraga
Copy link
Member

The sections for HTML5 Video and Capture with WebRTC seem outdated
because some functionalities described are included in the p5.dom library

https://github.com/processing/p5.js/wiki/Global-and-instance-mode#html5-video
https://github.com/processing/p5.js/wiki/Global-and-instance-mode#capture-with-webrtc

@calpa
Copy link

calpa commented Mar 25, 2017

@montoyamoraga
I find that in the p5.dom library has a createVideo() function, which maybe related to these sections. Except using this new function inside the p5.dom library, do you think that we need to build the example, in CodePen or JSFiddle under this section?

p5.dom docs - creating Video

@eJohnstonePhd1991
Copy link
Contributor

I can update the wiki entries to illustrate the new p5 video functionality, if no one is already on it.

@sleep-404
Copy link

@eJohnstonePhd1991 are you working on it ?

@eJohnstonePhd1991
Copy link
Contributor

@sleep-404
I haven't started working on it yet, so feel free to start on it yourself if you want.

@sleep-404
Copy link

cool , I'm trying to understand what exactly i need to do

@eJohnstonePhd1991
Copy link
Contributor

I think what needs to be done is to update the examples in the links above, since the html5 features they show can now be implemented with methods from the p5.dom library.

@sleep-404
Copy link

sleep-404 commented Jan 24, 2018

Thank you @eJohnstonePhd1991 ,I understood what's needed to be done ..Will try to finish it as fast as possible
And sorry for the late response :)

@sleep-404
Copy link

sleep-404 commented Jan 24, 2018

https://github.com/sleep-404/p5_wiki/commit/eb71eb6d262b6f77d1d8acfbf8d4b7a6f0d937f3
Updated the html5 video part.
Are there any issues or suugestions ? If no can I do the same with capture ??

@sleep-404
Copy link

sleep-404 commented Jan 25, 2018

@lmccart
Is it okay? I have updated both the parts of the wiki with the help of p5.js references.
& thanks in advance for your precious time :)

@limzykenneth
Copy link
Member

@sleep-404 Thanks for your work! It's great. I had a close look at it and here are some areas which I think can do with some changes. I'll go ahead with making those changes if you don't mind, they are mostly grammatical errors or formatting errors, nothing major. Don't worry it's not your fault, I just want to make it clear so it won't be confusing to people whose first language isn't English. 😃

@sleep-404
Copy link

ohh sorry for that ..

@lmccart
Copy link
Member

lmccart commented Jan 26, 2018

thanks @sleep-404 and @limzykenneth!
looking at this closer, I'm not sure the video stuff should even be on this page. it looks like the original source it was copied from actually contained multiple sections, and only the first ones about global and instance mode pertain to the title of this page. the others should probably go in the beyond the canvas page instead

@sleep-404
Copy link

okay , will go through the wiki again and come up with better content and examples

@lmccart
Copy link
Member

lmccart commented Jan 26, 2018

oh I think the content is pretty good already, I think the two video sections at the end of this page can just be moved to the end of the other page I linked to, and we'd be set. please feel free to go ahead if you'd like to make that change.

@sleep-404
Copy link

on it !

@sleep-404
Copy link

sleep-404 commented Jan 27, 2018

@lmccart
Copy link
Member

lmccart commented Jan 27, 2018

great!

@lmccart lmccart closed this as completed Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants