Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Provide an IIFE bundle in the npm package #26

Closed
6 tasks
tbouffard opened this issue Jul 19, 2023 · 1 comment
Closed
6 tasks

[FEAT] Provide an IIFE bundle in the npm package #26

tbouffard opened this issue Jul 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@tbouffard
Copy link
Member

tbouffard commented Jul 19, 2023

Is your feature request related to a problem? Please describe.
The first version of the npm package only provide ES modules, so I cannot evaluate the add-ons directly in my browser along with bpmn-visualization

Describe the solution you'd like
Create the bundle with the bundler of your choice. In bpmn-visualization, we use Rollup. We may reuse it to capitalize.

⚠️ WARNING ⚠️ bpmn-visualization (and its implementation) must not be integrated in the bundles. HTML pages will load it by themself. Remember that the code of bpmn-visualization is available as a global bpmnVisu object, so the produced IIFE bundle should use this global object. https://rollupjs.org/configuration-options/#output-globals may help.

Tasks

@tbouffard tbouffard added the enhancement New feature or request label Jul 19, 2023
@tbouffard tbouffard modified the milestones: 0.2.0, 0.3..0 Jul 19, 2023
@tbouffard tbouffard modified the milestones: 0.3.0, 0.4.0 Aug 21, 2023
@tbouffard tbouffard modified the milestones: 0.4.0, 0.5.0 Sep 4, 2023
@tbouffard tbouffard modified the milestones: 0.5.0, 0.6.0 Sep 13, 2023
@tbouffard tbouffard modified the milestones: 0.6.0, 0.7.0 Oct 3, 2023
@tbouffard tbouffard removed this from the 0.7.0 milestone Aug 28, 2024
@tbouffard
Copy link
Member Author

We have decided not to pursue this feature. The main objective of this library is to experiment with ways to enhance tree-shaking for bpmn-visualization by offering tree-shakable features. Providing an IIFE bundle does not align with this goal.

So closing this issue.

@tbouffard tbouffard closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant