Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] supplier: create popovers only once #74

Open
assynour opened this issue Mar 23, 2023 · 0 comments
Open

[BUG] supplier: create popovers only once #74

assynour opened this issue Mar 23, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@assynour
Copy link
Contributor

assynour commented Mar 23, 2023

Describe the bug
In the supplier process, when clicking on the button Generate, the process enters in a loop. Currently new popovers are created for the activities retrieve email suggestion and review and adapt email each time the button Generateis clicked.

Expected behavior
The method addInfo (shown below in its current implementation) should first test whether there's already and existing popover attached to the elements.
If so, the popover is shown, otherwise the popover is created.

  protected addInfo(activityId: string) {
    const tippyInstance = this.supplierMonitoring.addInfoOnChatGptActivity(activityId);
    tippyInstance.setProps({
      trigger: 'manual',
      arrow: false,
      hideOnClick: false,
    });
    return tippyInstance;
  }
@assynour assynour added the bug Something isn't working label Mar 23, 2023
@assynour assynour added this to the Priority 2 milestone Mar 23, 2023
@assynour assynour self-assigned this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants