-
Notifications
You must be signed in to change notification settings - Fork 9
PEM format doesn't play nicely with now.sh secrets/env vars #17
Comments
With Heroku, you're able to set the key by surrounding it in quotes. Does something like this not work on Now?
There's also code already that will replace literal https://github.com/probot/probot/blob/master/lib/private-key.js#L18-L20 |
Unfortunately not. Both of the following don't work correctly:
Like I said, the root problem is with now.sh, but it's definitely a source of friction in any case. |
I know that jumping in with "me too!" responses is not tactful and all, but I think that if nothing is going to be done to fix this, the documentation for deploying with Specifically:
|
@hakusaro sorry that this is still happening 🙁 When you first came to it, did you see the deployment docs? If you did and those are wrong, good to know and we should update them. If you did not see those, then maybe we need to surface the docs a little bit better. Did you see this issue? If this actually works (I haven't tried it myself) we should add that to the deployment docs.
100% agreed. You're welcome to make a PR, or we'll hopefully get a chance to do it soon! |
@JasonEtco I didn't see that issue. The solution I went with was adding |
Is this still causing friction? If so, please comment with any updates or addition details. |
I'm guessing it is given #25 but I'm not sure, personally. |
A workaround was documented few days ago https://github.com/probot/probot/blob/master/docs/deployment.md#now thanks to probot/probot#548 But it's not available at https://probot.github.io/docs/deployment/#now
|
Is this still causing friction? If so, please comment with any updates or addition details. |
There's now a built-in solution for this: probot/probot#624 |
This should also work: |
Currently, there's an ugly workaround required to provide the private key on CI deployments to now.sh.
The root cause is vercel/vercel#749, but I wonder if it would be worthwhile for probot to accept a base64 encoded private key via a
PRIVATE_KEY_BASE64
env variable, so decoding it manually is not required.This is arguably feature bloat, but would definitely reduce the friction of a common use case.
The text was updated successfully, but these errors were encountered: