Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package wppl files concatenated in differing orders between browser/node #209

Closed
null-a opened this issue Sep 21, 2015 · 1 comment · Fixed by #241
Closed

Package wppl files concatenated in differing orders between browser/node #209

null-a opened this issue Sep 21, 2015 · 1 comment · Fixed by #241
Assignees
Labels

Comments

@null-a
Copy link
Member

null-a commented Sep 21, 2015

This is problematic when there are dependencies between packages.

The current implementation for the browser is perhaps the most natural as packages are loaded in the order they are specified on the command line, and individual files within a package are loaded in the order they appear in package.json.

@null-a null-a self-assigned this Sep 21, 2015
@stuhlmueller
Copy link
Member

Yes, predictable load ordering is desirable, and making the command line act like the browser implementation is a natural short-term solution.

Longer-term, this should probably be more analogous to node packages in general, and offload as much of the work as possible to existing infrastructure. That is, for dependencies between packages, recursively require other packages via package.json. For files within a package, including wppl files, use explicit export/import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants